Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BE68619742 for ; Fri, 25 Mar 2016 03:44:14 +0000 (UTC) Received: (qmail 68245 invoked by uid 500); 25 Mar 2016 03:44:14 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 68194 invoked by uid 500); 25 Mar 2016 03:44:14 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 68183 invoked by uid 99); 25 Mar 2016 03:44:13 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Mar 2016 03:44:13 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id B751EDFB79; Fri, 25 Mar 2016 03:44:13 +0000 (UTC) From: jacques-n To: dev@drill.apache.org Reply-To: dev@drill.apache.org References: In-Reply-To: Subject: [GitHub] drill pull request: DRILL-4531: Add a Drill customized rule for pu... Content-Type: text/plain Message-Id: <20160325034413.B751EDFB79@git1-us-west.apache.org> Date: Fri, 25 Mar 2016 03:44:13 +0000 (UTC) Github user jacques-n commented on the pull request: https://github.com/apache/drill/pull/444#issuecomment-201124173 I think there is another bug here. DrillAggregateRel should assert when a none convention is passed in. If you add that assertion where do we fail? We should fix that --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---