Return-Path: 
 <dev-return-21094-apmail-drill-dev-archive=drill.apache.org@drill.apache.org>
X-Original-To: apmail-drill-dev-archive@www.apache.org
Delivered-To: apmail-drill-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id EEB0219AAE
	for <apmail-drill-dev-archive@www.apache.org>;
 Thu, 17 Mar 2016 04:44:52 +0000 (UTC)
Received: (qmail 25611 invoked by uid 500); 17 Mar 2016 04:44:52 -0000
Delivered-To: apmail-drill-dev-archive@drill.apache.org
Received: (qmail 25558 invoked by uid 500); 17 Mar 2016 04:44:52 -0000
Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@drill.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@drill.apache.org>
List-Post: <mailto:dev@drill.apache.org>
List-Id: <dev.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list dev@drill.apache.org
Received: (qmail 25547 invoked by uid 99); 17 Mar 2016 04:44:52 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Mar 2016 04:44:52 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 4BCA5DFA43; Thu, 17 Mar 2016 04:44:52 +0000 (UTC)
From: hsuanyi <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-397-drill@git.apache.org>
In-Reply-To: <git-pr-397-drill@git.apache.org>
Subject: [GitHub] drill pull request: Drill 4372 review
Content-Type: text/plain
Message-Id: <20160317044452.4BCA5DFA43@git1-us-west.apache.org>
Date: Thu, 17 Mar 2016 04:44:52 +0000 (UTC)

Github user hsuanyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/397#discussion_r56454989
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillOperatorTable.java ---
    @@ -26,34 +33,88 @@
     import org.apache.calcite.sql.SqlOperatorTable;
     import org.apache.calcite.sql.SqlSyntax;
     import org.apache.calcite.sql.fun.SqlStdOperatorTable;
    +import org.apache.drill.exec.planner.physical.PlannerSettings;
    +import org.apache.drill.exec.server.options.SystemOptionManager;
     
     import java.util.List;
    +import java.util.Map;
     
    +/**
    + * Implementation of {@link SqlOperatorTable} that contains standard operators and functions provided through
    + * {@link #inner SqlStdOperatorTable}, and Drill User Defined Functions.
    + */
     public class DrillOperatorTable extends SqlStdOperatorTable {
    -  static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(DrillOperatorTable.class);
    -
    +//  private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(DrillOperatorTable.class);
       private static final SqlOperatorTable inner = SqlStdOperatorTable.instance();
    -  private List<SqlOperator> operators;
    -  private ArrayListMultimap<String, SqlOperator> opMap = ArrayListMultimap.create();
    +  private final List<SqlOperator> operatorsCalcite = Lists.newArrayList();
    +  private final List<SqlOperator> operatorsDefault = Lists.newArrayList();
    +  private final List<SqlOperator> operatorsInferernce = Lists.newArrayList();
    +  private final Map<SqlOperator, SqlOperator> calciteToWrapper = Maps.newIdentityHashMap();
    +
    +  private final ArrayListMultimap<String, SqlOperator> opMapDefault = ArrayListMultimap.create();
    +  private final ArrayListMultimap<String, SqlOperator> opMapInferernce = ArrayListMultimap.create();
    +
    +  private final SystemOptionManager systemOptionManager;
    --- End diff --
    
    addressed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---