drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaltekruse <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4482: Avro subselection broken by 4382
Date Wed, 09 Mar 2016 01:35:56 GMT
GitHub user jaltekruse opened a pull request:

    https://github.com/apache/drill/pull/419

    DRILL-4482: Avro subselection broken by 4382

    This fix includes a number of test updates to ensure Avro files are being read correctly.
    
    The branch includes 4441, which is on a different PR, but touched some of the same code,
so I just based this fix on that branch.
    
    The actual regression fix is in the AvroRecordReader, in the case of a Union, we should
not be created a child of the fieldSelection, which was properly done in the case with maps
and records.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jaltekruse/incubator-drill 4441-4482-avro-bugs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/419.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #419
    
----
commit 56048dae231a6c11c2650384da6893a8c1011fee
Author: Jason Altekruse <altekrusejason@gmail.com>
Date:   2016-02-26T17:55:05Z

    DRILL-4441: Fix varchar data read out of Avro filtering incorrectly due to metadata bug
    
    The precision of the Varchar datatype was not being set causing inconsistent
    truncation of values to the default length of 1. Fixed the same issue with varbinary.
    
    The test framework was previously taking a string as the baseline for a binary value,
    which cannot express all possible values. Fixed the test to intstead use a byte array.
    Thie required updating the hive tests that were using the old method of specifying
    baselines with a String.
    
    Fix cast to varbinary when reading from a data source with schema needed for writing
    a test.

commit 15209ea07a41b0a7bdccb382950b5738bd229b18
Author: Jason Altekruse <altekrusejason@gmail.com>
Date:   2016-03-08T22:16:03Z

    DRILL-4482: Fix Avro nested field selection regression
    
    Update some of the Avro tests to properly verify their results,
    others still need to be fixed. These will be addressed in DRILL-4110.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message