drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaltekruse <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4375: Fix the maven release profile
Date Wed, 02 Mar 2016 18:43:37 GMT
GitHub user jaltekruse opened a pull request:

    https://github.com/apache/drill/pull/402

    DRILL-4375: Fix the maven release profile

    This generated pom file was being discovered and maven was trying to
    run the target directory in jdbc-all as a submodule.
    
    This change reverts to the default output location (the module root)
    and adds corresponding .gitignore and RAT exclude entries. NOTE:
    this is considered bad practice as generated files should appear in
    the target directory and be removed upon a maven clean. This default
    location is considered to be a known shortcoming of the shade plugin.
    
    Also updated integration test for the jdbc-all jar with small
    path change, as changing the location of the dependency-reduced-pom.xml
    actually changed the directory the test was being executed from.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jaltekruse/incubator-drill 4375-fix-release-profile-shade-issues

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/402.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #402
    
----
commit d4ac16158f532fd43409ebbf6eec2d643fc4ff06
Author: Jason Altekruse <altekrusejason@gmail.com>
Date:   2016-02-02T07:17:37Z

    DRILL-4375: Fix the maven release profile
    
    This generated pom file was being discovered and maven was trying to
    run the target directory in jdbc-all as a submodule.
    
    This change reverts to the default output location (the module root)
    and adds corresponding .gitignore and RAT exclude entries. NOTE:
    this is considered bad practice as generated files should appear in
    the target directory and be removed upon a maven clean. This default
    location is considered to be a known shortcoming of the shade plugin.
    
    Also updated integration test for the jdbc-all jar with small
    path change, as changing the location of the dependency-reduced-pom.xml
    actually changed the directory the test was being executed from.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message