drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From parthchandra <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4523: Disallow using loopback address in...
Date Thu, 31 Mar 2016 21:25:21 GMT
Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/445#discussion_r58130327
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/service/ServiceEngine.java
---
    @@ -177,6 +180,16 @@ public void run() {
         });
       }
     
    +  /** If we are in distributed mode, disallow using loopback address to register new
drillbit
    +   *  unless zookeeper is on the same node with drillbit. */
    +  private void checkLoopbackAddress(String address) throws DrillbitStartupException,
UnknownHostException {
    +    String coordAddress = StringUtils.substringBefore(config.getString(ExecConstants.ZK_CONNECTION),
":");
    --- End diff --
    
    At this point, how do you know you're in distributed and not embedded mode? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message