drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4504: Create an event loop for each of [...
Date Fri, 25 Mar 2016 07:56:33 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/429#discussion_r57426094
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/BootStrapContext.java
---
    @@ -50,8 +52,12 @@
       public BootStrapContext(DrillConfig config, ScanResult classpathScan) {
         this.config = config;
         this.classpathScan = classpathScan;
    -    this.loop = TransportCheck.createEventLoopGroup(config.getInt(ExecConstants.BIT_SERVER_RPC_THREADS),
"BitServer-");
    -    this.loop2 = TransportCheck.createEventLoopGroup(config.getInt(ExecConstants.BIT_SERVER_RPC_THREADS),
"BitClient-");
    +    this.controlLoopGroup = TransportCheck.createEventLoopGroup(config.getInt(ExecConstants.BIT_SERVER_RPC_THREADS),
    --- End diff --
    
    Done. I am hesitant to lower the control loop size until all blocking calls in handling
requests are removed (e.g. cancelling an executor while fragment is starting up).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message