drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hsuanyi <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4525: Allow SqlBetweenOperator to accept...
Date Wed, 23 Mar 2016 22:51:35 GMT
Github user hsuanyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/438#discussion_r57250944
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillOperatorTable.java
---
    @@ -157,9 +159,23 @@ private void populateWrappedCalciteOperators() {
           } else if(calciteOperator instanceof SqlFunction) {
             wrapper = new DrillCalciteSqlFunctionWrapper((SqlFunction) calciteOperator,
                 getFunctionListWithInference(calciteOperator.getName()));
    +      } else if(calciteOperator instanceof SqlBetweenOperator) {
    +        // During the procedure of converting to RexNode,
    +        // StandardConvertletTable.convertBetween expects the SqlOperator to be a subclass
of SqlBetweenOperator
    +        final SqlBetweenOperator sqlBetweenOperator = (SqlBetweenOperator) calciteOperator;
    +        wrapper = new SqlBetweenOperator(sqlBetweenOperator.flag, sqlBetweenOperator.isNegated())
{
    +          @Override
    +          public boolean checkOperandTypes(
    --- End diff --
    
    Correct. Otherwise, the regression reported in this DRILL-4525 will be failed by Calcite
because Calcite does not allow between to be operated on timestamp and date.
    
    By the way, this pull request is closed. The correct pull request is this one:
    https://github.com/apache/drill/pull/439


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message