drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request: Drill 4372 review
Date Fri, 18 Mar 2016 17:26:26 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/397#discussion_r56692131
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillOperatorTable.java
---
    @@ -26,34 +33,93 @@
     import org.apache.calcite.sql.SqlOperatorTable;
     import org.apache.calcite.sql.SqlSyntax;
     import org.apache.calcite.sql.fun.SqlStdOperatorTable;
    +import org.apache.drill.exec.planner.physical.PlannerSettings;
    +import org.apache.drill.exec.server.options.OptionManager;
    +import org.apache.drill.exec.server.options.SystemOptionManager;
     
     import java.util.List;
    +import java.util.Map;
     
    +/**
    + * Implementation of {@link SqlOperatorTable} that contains standard operators and functions
provided through
    + * {@link #inner SqlStdOperatorTable}, and Drill User Defined Functions.
    + */
     public class DrillOperatorTable extends SqlStdOperatorTable {
    -  static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(DrillOperatorTable.class);
    -
    +//  private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(DrillOperatorTable.class);
       private static final SqlOperatorTable inner = SqlStdOperatorTable.instance();
    -  private List<SqlOperator> operators;
    -  private ArrayListMultimap<String, SqlOperator> opMap = ArrayListMultimap.create();
    +  private final List<SqlOperator> calciteOperators = Lists.newArrayList();
    +  private final List<SqlOperator> drillOperatorsWithoutInference = Lists.newArrayList();
    +  private final List<SqlOperator> drillOperatorsWithInference = Lists.newArrayList();
    +  private final Map<SqlOperator, SqlOperator> calciteToWrapper = Maps.newIdentityHashMap();
    +
    +  private final ArrayListMultimap<String, SqlOperator> drillOperatorsWithoutInferenceMap
= ArrayListMultimap.create();
    +  private final ArrayListMultimap<String, SqlOperator> drillOperatorsWithInferenceMap
= ArrayListMultimap.create();
     
    -  public DrillOperatorTable(FunctionImplementationRegistry registry) {
    -    operators = Lists.newArrayList();
    -    operators.addAll(inner.getOperatorList());
    +  private final OptionManager systemOptionManager;
     
    +  public DrillOperatorTable(FunctionImplementationRegistry registry, SystemOptionManager
systemOptionManager) {
    --- End diff --
    
    `OptionManager systemOptionManager`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message