drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hsuanyi <...@git.apache.org>
Subject [GitHub] drill pull request: Drill 4372 review
Date Wed, 16 Mar 2016 23:41:10 GMT
Github user hsuanyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/397#discussion_r56434976
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlAggOperatorNotInfer.java
---
    @@ -0,0 +1,43 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + * <p/>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p/>
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.planner.sql;
    +
    +import org.apache.calcite.rel.type.RelDataType;
    +import org.apache.calcite.rel.type.RelDataTypeFactory;
    +import org.apache.calcite.sql.SqlCall;
    +import org.apache.calcite.sql.type.SqlTypeName;
    +import org.apache.calcite.sql.validate.SqlValidator;
    +import org.apache.calcite.sql.validate.SqlValidatorScope;
    +import org.apache.drill.exec.expr.fn.DrillFuncHolder;
    +
    +import java.util.ArrayList;
    +
    +public class DrillSqlAggOperatorNotInfer extends DrillSqlAggOperator {
    +  public DrillSqlAggOperatorNotInfer(String name, int argCount) {
    +    super(name, new ArrayList<DrillFuncHolder>(), argCount, argCount, DynamicReturnType.INSTANCE);
    +  }
    +
    +  @Override
    +  public RelDataType deriveType(SqlValidator validator, SqlValidatorScope scope, SqlCall
call) {
    +    return getAny(validator.getTypeFactory());
    +  }
    +
    +  private RelDataType getAny(RelDataTypeFactory factory){
    +    return factory.createSqlType(SqlTypeName.ANY);
    --- End diff --
    
    DrillSqlAggOperatorNotInfer.java corresponds to the DrillSqlAggOperator in the old code[1].
When the inference option is being turned off, we want to fall back to the original behavior
as close as possible. With that in mind, I was trying to not change the logic too much.
    
    [1]https://github.com/apache/drill/blob/d7eebec41a1636055be1b2c79b693d76c52d8932/exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlAggOperator.java#L50


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message