drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request: Drill 4372 review
Date Wed, 16 Mar 2016 23:04:14 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/397#discussion_r56431177
  
    --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/HiveUDFOperator.java
---
    @@ -18,28 +18,20 @@
     
     package org.apache.drill.exec.planner.sql;
     
    -import com.fasterxml.jackson.databind.type.TypeFactory;
    -import org.apache.calcite.rel.type.RelDataType;
    -import org.apache.calcite.rel.type.RelDataTypeFactory;
    -import org.apache.calcite.sql.SqlCall;
     import org.apache.calcite.sql.SqlCallBinding;
     import org.apache.calcite.sql.SqlFunction;
     import org.apache.calcite.sql.SqlFunctionCategory;
     import org.apache.calcite.sql.SqlIdentifier;
     import org.apache.calcite.sql.SqlOperandCountRange;
     import org.apache.calcite.sql.SqlOperator;
    -import org.apache.calcite.sql.SqlOperatorBinding;
     import org.apache.calcite.sql.parser.SqlParserPos;
     import org.apache.calcite.sql.type.SqlOperandCountRanges;
     import org.apache.calcite.sql.type.SqlOperandTypeChecker;
    -import org.apache.calcite.sql.type.SqlTypeName;
    -import org.apache.calcite.sql.validate.SqlValidator;
    -import org.apache.calcite.sql.validate.SqlValidatorScope;
    +import org.apache.calcite.sql.type.SqlReturnTypeInference;
     
     public class HiveUDFOperator extends SqlFunction {
    -
    -  public HiveUDFOperator(String name) {
    -    super(new SqlIdentifier(name, SqlParserPos.ZERO), DynamicReturnType.INSTANCE, null,
new ArgChecker(), null,
    +  public HiveUDFOperator(String name, SqlReturnTypeInference sqlReturnTypeInference)
{
    +    super(new SqlIdentifier(name, SqlParserPos.ZERO), sqlReturnTypeInference, null, new
ArgChecker(), null,
    --- End diff --
    
    Use ArgChecker.INSTANCE (and make that final)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message