drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaltekruse <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4459: SchemaChangeException while queryi...
Date Wed, 16 Mar 2016 15:30:10 GMT
Github user jaltekruse commented on a diff in the pull request:

    https://github.com/apache/drill/pull/431#discussion_r56354881
  
    --- Diff: contrib/storage-hive/core/src/test/java/org/apache/drill/exec/fn/hive/TestInbuiltHiveUDFs.java
---
    @@ -43,4 +47,17 @@ public void testEncode() throws Exception {
             .baselineValues(new Object[] { null })
             .go();
       }
    +
    +   @Test // DRILL-4459
    +   public void testGetJsonObject() throws Exception {
    +        setColumnWidths(new int[]{260});
    +        String query = "select * from hive.simple_json where GET_JSON_OBJECT(simple_json.json,
'$.DocId') = 'DocId2'";
    +        List<QueryDataBatch> results = testSqlWithResults(query);
    +        String expected = "json\n" + "{\"DocId\":\"DocId2\",\"User\":{\"Id\":122,\"Username\":\"larry122\",\"Name\":"
+
    --- End diff --
    
    Can you specify this baseline as a complex object instead of a string? The testBuilder
can be used to check results against java POJOs and it includes helper methods listOF/mapOf
for building up complex structures.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message