drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4503: Write nulls as varchar when all_te...
Date Sun, 13 Mar 2016 23:57:11 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/428#discussion_r55946493
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
    @@ -402,7 +402,8 @@ private void writeDataAllText(MapWriter map, FieldSelection selection,
boolean m
             handleString(parser, map, fieldName);
             break;
           case VALUE_NULL:
    -        // do nothing as we don't have a type.
    --- End diff --
    
    Won't this cause both of these files to fail to read?
    
    FILE1
    {a: 4, b:null}
    {a:6, b: [1,2,3]}
    
    FILE2
    {a:4, b:null}
    {a:6, b: {x:1, y:2}}



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message