drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4490: Ensure the count generated by Conv...
Date Thu, 10 Mar 2016 02:21:32 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/423#discussion_r55625819
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestAggregateFunctions.java
---
    @@ -460,4 +466,23 @@ public void testGroupBySystemFuncFileSystemTable() throws Exception
{
       public void test4443() throws Exception {
         test("SELECT MIN(columns[1]) FROM dfs_test.`%s/agg/4443.csv` GROUP BY columns[0]",
TEST_RES_PATH);
       }
    +
    +  @Test
    +  public void testCountStarRequired() throws Exception {
    +    final String query = "select count(*) as col from cp.`tpch/region.parquet` limit
0";
    --- End diff --
    
    this does not have to be used with "limit 0", right? can you add one more case without
using "limit 0"?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message