drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4474: Ensure that ConvertCountToDirectSc...
Date Tue, 08 Mar 2016 23:01:14 GMT
Github user jinfengni commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ConvertCountToDirectScan.java
    @@ -103,6 +104,10 @@ public void onMatch(RelOptRuleCall call) {
    +    if (proj != null && !ProjectRemoveRule.isTrivial(proj)) {
    --- End diff --
    I have a patch, which works fine for Jacque's new unit test. It continues to use directScan
for simple count query. The patch is pending pre-commit & unit test run. Will update results

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message