drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4474: Ensure that ConvertCountToDirectSc...
Date Tue, 08 Mar 2016 21:17:56 GMT
Github user amansinha100 commented on the pull request:

    https://github.com/apache/drill/pull/406#issuecomment-193971973
  
    Agree with @jinfengni that the current fix can cause performance regression for simpler
count queries.  I will change my review to -1 and let's see how to get the proper nullability
check. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message