drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request: Drill 4372 review
Date Thu, 03 Mar 2016 18:20:38 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/397#discussion_r54922569
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java
---
    @@ -770,6 +770,65 @@ public void eval() {
         } // end of eval
       }
     
    +  /*
    +   * Fill up the string to length 'length' by prepending the character ' ' in the beginning
of 'text'.
    +   * If the string is already longer than length, then it is truncated (on the right).
    +   */
    +  @FunctionTemplate(name = "lpad", scope = FunctionScope.SIMPLE, nulls = NullHandling.NULL_IF_NULL)
    +  public static class LpadTwoArg implements DrillSimpleFunc {
    --- End diff --
    
    Please add unit test for these functions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message