Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: hsuanyi <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-377-drill@git.apache.org>
In-Reply-To: <git-pr-377-drill@git.apache.org>
Subject: [GitHub] drill pull request: Drill 4372 for review
Content-Type: text/plain
Message-Id: <20160221035520.5F1C2E0104@git1-us-west.apache.org>
Date: Sun, 21 Feb 2016 03:55:20 +0000 (UTC)

Github user hsuanyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/377#discussion_r53561348
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DummyFlatten.java ---
    @@ -32,6 +34,7 @@
     @FunctionTemplate(name = "flatten", scope = FunctionScope.SIMPLE, nulls = NullHandling.NULL_IF_NULL)
     public class DummyFlatten implements DrillSimpleFunc {
     
    +  @Param VarCharHolder in;
    --- End diff --
    
    Along the same argument as the above:
    https://github.com/hsuanyi/incubator-drill/blob/DRILL-4372_For_Review/exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperator.java#L86
    
    Addressed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---