Return-Path: 
 <dev-return-20304-apmail-drill-dev-archive=drill.apache.org@drill.apache.org>
X-Original-To: apmail-drill-dev-archive@www.apache.org
Delivered-To: apmail-drill-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 78320188D4
	for <apmail-drill-dev-archive@www.apache.org>;
 Fri, 19 Feb 2016 23:25:35 +0000 (UTC)
Received: (qmail 83212 invoked by uid 500); 19 Feb 2016 23:25:35 -0000
Delivered-To: apmail-drill-dev-archive@drill.apache.org
Received: (qmail 83155 invoked by uid 500); 19 Feb 2016 23:25:35 -0000
Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@drill.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@drill.apache.org>
List-Post: <mailto:dev@drill.apache.org>
List-Id: <dev.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list dev@drill.apache.org
Received: (qmail 83139 invoked by uid 99); 19 Feb 2016 23:25:35 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Feb 2016 23:25:35 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id DFBB2E0092; Fri, 19 Feb 2016 23:25:34 +0000 (UTC)
From: hsuanyi <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-377-drill@git.apache.org>
In-Reply-To: <git-pr-377-drill@git.apache.org>
Subject: [GitHub] drill pull request: Drill 4372 for review
Content-Type: text/plain
Message-Id: <20160219232534.DFBB2E0092@git1-us-west.apache.org>
Date: Fri, 19 Feb 2016 23:25:34 +0000 (UTC)

Github user hsuanyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/377#discussion_r53533306
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFuncHolder.java ---
    @@ -264,7 +265,24 @@ public boolean isFieldReader(int i) {
         return this.parameters[i].isFieldReader;
       }
     
    -  public MajorType getReturnType(List<LogicalExpression> args) {
    +  public static List<MajorType> getResultType(List<LogicalExpression> expressions) {
    +    final List<MajorType> argumentTypes = Lists.newArrayList();
    +    for (LogicalExpression expression : expressions) {
    +      argumentTypes.add(expression.getMajorType());
    +    }
    +    return argumentTypes;
    +  }
    +
    +  public final MajorType getReturnTypeMajorType(final List<MajorType> types) {
    +    final List<LogicalExpression> expressions = Lists.newArrayList();
    +    for(final MajorType type : types) {
    +      final LogicalExpression dumbExpr = new DumbLogicalExpression(type);
    --- End diff --
    
    @hnfgns done! take a look please.
    
    @jinfengni make sense. working on it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---