drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From parthchandra <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4313: Improve method of picking a random...
Date Mon, 29 Feb 2016 03:24:46 GMT
GitHub user parthchandra opened a pull request:


    DRILL-4313: Improve method of picking a random drillbit from the C++ client

    Submitting as multiple commits to make review easier
    Changes -
    1) Made the logging thread safe. 
    2) Use Boost random method generation instead of C rand() method.
    3) Include git properties in build and print build commit id in log.
    4) Add interface to get client error based on query handle. (Previous API always got back
the last error that occurred). This could lead to clobbering of error messages when multiple
errors were encountered.
    5) Allow pooled client connections. Every query submitted used a different connection
from the pool. The pool is filled lazily. Disabled by default . Can be enabled by (and pool
size defined by) setting environment variable(s).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/parthchandra/incubator-drill DRILL-4313_2

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #396
commit a03ae1ec30ed28a1e15ffc8162ab560fdd544411
Author: Parth Chandra <parthc@apache.org>
Date:   2016-02-12T23:42:53Z

    DRILL-4313: C++ Client - Thread safe Logging

commit b494dc184578853167a3f6330c92beb475b74835
Author: Parth Chandra <parthc@apache.org>
Date:   2016-02-12T22:03:37Z

    DRILL-4313: Update random drill bit selection. Shuffle the list initially, then round
    Add Utility methods to get random numbers and to shuffle and add vectors.
    Whitespace cleanup

commit 629142a295ecb4c79f37f31d5dd34d4b8a889638
Author: Parth Chandra <parthc@apache.org>
Date:   2016-02-18T23:53:35Z

    DRILL-4313: C++ client - Add Git properties to build and print to log.

commit 273cfc4bac96e4b65f66e6a7eea84642d50ecf50
Author: Parth Chandra <parthc@apache.org>
Date:   2016-02-22T19:21:58Z

    DRILL-4313: - Add interface to get error based on query handle.

commit f399792c2ca48e5d2c41b3daba4a2a3274992fcc
Author: Parth Chandra <parthc@apache.org>
Date:   2016-02-13T06:38:51Z

    DRILL-4313: Add support for Pooled connections.
    Allows switching between pooled and unpooled connections based on
    environment variables


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message