drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From laurentgo <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4332: Makes vector comparison order stab...
Date Tue, 23 Feb 2016 22:29:11 GMT
GitHub user laurentgo opened a pull request:

    https://github.com/apache/drill/pull/389

    DRILL-4332: Makes vector comparison order stable in test framework

    In the test framework, a vector is a map of <String, Object>. When comparing
    actual values with baseline, the comparison is made column by column, but
    a HashMap key ordering is not guaranteed, and the ordering actually changed
    between Java7 and Java8 in Oracle/OpenJDK.
    
    Replacing HashMap with TreeMap which has a guaranteed ordering by design.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laurentgo/drill laurent/DRILL-4332

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/389.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #389
    
----
commit 7de03c933e78751eb5f95fa49513f4d57a72a218
Author: Laurent Goujon <laurent@dremio.com>
Date:   2016-02-23T22:14:37Z

    DRILL-4332: Makes vector comparison order stable in test framework
    
    In the test framework, a vector is a map of <String, Object>. When comparing
    actual values with baseline, the comparison is made column by column, but
    a HashMap key ordering is not guaranteed, and the ordering actually changed
    between Java7 and Java8 in Oracle/OpenJDK.
    
    Replacing HashMap with TreeMap which has a guaranteed ordering by design.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message