drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4287: During initial DrillTable creation...
Date Sun, 14 Feb 2016 17:30:39 GMT
GitHub user amansinha100 opened a pull request:

    https://github.com/apache/drill/pull/376

    DRILL-4287: During initial DrillTable creation don't read the metadat…

    …a cache file; instead do it during ParquetGroupScan.
    
    Maintain state in FileSelection to keep track of whether certain operations have been
done on that selection.
    
    Remove ParquetFileSelection since its only purpose was to carry the metadata cache information
which is not needed anymore.
    
    Conflicts:
    	exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java
    	exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFileSelection.java
    
    Resolve issues after rebasing:
    
    1) JsonIgnore fileSelection in ParquetGroupScan
    2) FileSysemPartitionDescriptor change.
    
    Conflicts:
    	exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java
    
    DRILL-4287: Address code review comments and follow-up changes after rebasing:
    
    - In FileSelection: updated call to the Stopwatch, set all flags appropriately in minusDirectories(),
modify supportDirPruning()
    - In ParquetGroupScan: Simplify directory checking in constructor,  set the parquetTableMetadata
field after reading metadata cache.
    - Fix unit tests to use an alias for the reserved dir<N> columns as partition-by
columns.
    
    More follow-up changes:
    
     - Get rid of fileSelection attribute in ParquetGroupScan
     - Initialize entries after expanding the selection when metadata cache is used
     - For non-metadata cache, don't do any expansion in the constructor; let init() handle
it
     - In FileSystemPartitionDescriptor, the createPartitionSublists is modified to check
for parquet scan
    
    When reading from metadata cache , ensure selection root does contain the scheme and authority
prefix.  Minor refactoring.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/amansinha100/incubator-drill DRILL-4287-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/376.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #376
    
----
commit 79508e3d08baa49ec2d2d7480dd278e77b99e527
Author: Aman Sinha <asinha@maprtech.com>
Date:   2016-01-18T18:26:59Z

    DRILL-4287: During initial DrillTable creation don't read the metadata cache file; instead
do it during ParquetGroupScan.
    
    Maintain state in FileSelection to keep track of whether certain operations have been
done on that selection.
    
    Remove ParquetFileSelection since its only purpose was to carry the metadata cache information
which is not needed anymore.
    
    Conflicts:
    	exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java
    	exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFileSelection.java
    
    Resolve issues after rebasing:
    
    1) JsonIgnore fileSelection in ParquetGroupScan
    2) FileSysemPartitionDescriptor change.
    
    Conflicts:
    	exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java
    
    DRILL-4287: Address code review comments and follow-up changes after rebasing:
    
    - In FileSelection: updated call to the Stopwatch, set all flags appropriately in minusDirectories(),
modify supportDirPruning()
    - In ParquetGroupScan: Simplify directory checking in constructor,  set the parquetTableMetadata
field after reading metadata cache.
    - Fix unit tests to use an alias for the reserved dir<N> columns as partition-by
columns.
    
    More follow-up changes:
    
     - Get rid of fileSelection attribute in ParquetGroupScan
     - Initialize entries after expanding the selection when metadata cache is used
     - For non-metadata cache, don't do any expansion in the constructor; let init() handle
it
     - In FileSystemPartitionDescriptor, the createPartitionSublists is modified to check
for parquet scan
    
    When reading from metadata cache , ensure selection root does contain the scheme and authority
prefix.  Minor refactoring.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message