drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vkorukanti <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4354: Remove sessions in anonymous (auth...
Date Fri, 26 Feb 2016 17:24:25 GMT
Github user vkorukanti commented on a diff in the pull request:

    https://github.com/apache/drill/pull/360#discussion_r54273249
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillUserPrincipal.java
---
    @@ -60,13 +63,21 @@ public String getName() {
       }
     
       /**
    -   * @return Return {@link DrillClient} instanced with credentials of this user principal.
    +   * @return Return {@link DrillClient} instanced with credentials of this user principal.
Returned {@link DrillClient}
    +   * must be returned using {@link #recycleDrillClient(DrillClient)} for proper resource
cleanup.
        */
    -  public DrillClient getDrillClient() {
    +  public DrillClient getDrillClient() throws IOException {
         return drillClient;
       }
     
       /**
    +   *
    --- End diff --
    
    added javadoc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message