drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaltekruse <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4411: hash join should limit batch based...
Date Wed, 24 Feb 2016 22:22:05 GMT
Github user jaltekruse commented on a diff in the pull request:

    https://github.com/apache/drill/pull/381#discussion_r54017219
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinProbeTemplate.java
---
    @@ -47,7 +47,11 @@
     
       private HashJoinBatch outgoingJoinBatch = null;
     
    -  private static final int TARGET_RECORDS_PER_BATCH = 4000;
    +  private int targetRecordsPerBatch = 4000;
    --- End diff --
    
    I would add a comment here about when this value will be mutated as we are moving it away
from immutability, and most of the other operators currently have this as an immutable value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message