drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request: Drill 4372 for review
Date Sat, 20 Feb 2016 03:13:17 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/377#discussion_r53543354
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/annotations/FunctionTemplate.java
---
    @@ -55,12 +55,19 @@
     
       FunctionScope scope();
       NullHandling nulls() default NullHandling.INTERNAL;
    +
    +  /**
    +   * This method tells if the number of argument(s) for a function is FIXED or VARIABLE.
Since most functions expect
    +   * receiving fixed number of argument(s), the default value is FIXED.
    +   */
    +  FunctionArgumentNumber argNumber() default FunctionArgumentNumber.FIXED;
    --- End diff --
    
    There would be no need for dummy functions too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message