drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request: Drill 4372 for review
Date Sat, 20 Feb 2016 02:58:48 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/377#discussion_r53543118
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFuncHolder.java
---
    @@ -264,22 +265,43 @@ public boolean isFieldReader(int i) {
         return this.parameters[i].isFieldReader;
       }
     
    -  public MajorType getReturnType(List<LogicalExpression> args) {
    +  public static List<MajorType> getResultType(List<LogicalExpression> expressions)
{
    +    final List<MajorType> argumentTypes = Lists.newArrayList();
    +    for (LogicalExpression expression : expressions) {
    +      argumentTypes.add(expression.getMajorType());
    +    }
    +    return argumentTypes;
    +  }
    +
    +  public MajorType getReturnType(final List<LogicalExpression> logicalExpressions)
{
    +    final List<MajorType> types = Lists.newArrayList();
    +    for(final LogicalExpression logicalExpression : logicalExpressions) {
    +      types.add(logicalExpression.getMajorType());
    +    }
    +    return getReturnTypeMajorType(types);
    +  }
    +
    +  public MajorType getReturnTypeMajorType(final List<MajorType> types) {
    --- End diff --
    
    please rename this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message