drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hsuanyi <...@git.apache.org>
Subject [GitHub] drill pull request: Drill 4372 for review
Date Sat, 20 Feb 2016 01:31:50 GMT
Github user hsuanyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/377#discussion_r53540918
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/conv/DummyConvertFrom.java
---
    @@ -32,6 +34,8 @@
     @FunctionTemplate(name = "convert_from", scope = FunctionScope.SIMPLE, nulls = NullHandling.NULL_IF_NULL)
     public class DummyConvertFrom implements DrillSimpleFunc {
     
    +  @Param VarCharHolder in1;
    +  @Param VarCharHolder in2;
       @Output VarBinaryHolder out;
    --- End diff --
    
    To honest, I was struggling at this point a lot. Since this is a dummy function whose
real implementation won't be determined until DrillOptiq. Thus, the return type can be just
chosen arbitrarily. 
    
    How about letting me add the above as comment in the code?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message