drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hsuanyi <...@git.apache.org>
Subject [GitHub] drill pull request: Drill 4372 for review
Date Fri, 19 Feb 2016 23:25:34 GMT
Github user hsuanyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/377#discussion_r53533306
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFuncHolder.java
---
    @@ -264,7 +265,24 @@ public boolean isFieldReader(int i) {
         return this.parameters[i].isFieldReader;
       }
     
    -  public MajorType getReturnType(List<LogicalExpression> args) {
    +  public static List<MajorType> getResultType(List<LogicalExpression> expressions)
{
    +    final List<MajorType> argumentTypes = Lists.newArrayList();
    +    for (LogicalExpression expression : expressions) {
    +      argumentTypes.add(expression.getMajorType());
    +    }
    +    return argumentTypes;
    +  }
    +
    +  public final MajorType getReturnTypeMajorType(final List<MajorType> types) {
    +    final List<LogicalExpression> expressions = Lists.newArrayList();
    +    for(final MajorType type : types) {
    +      final LogicalExpression dumbExpr = new DumbLogicalExpression(type);
    --- End diff --
    
    @hnfgns done! take a look please.
    
    @jinfengni make sense. working on it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message