drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hsuanyi <...@git.apache.org>
Subject [GitHub] drill pull request: Drill 4372 for review
Date Fri, 19 Feb 2016 23:24:37 GMT
Github user hsuanyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/377#discussion_r53533236
  
    --- Diff: exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/Extract.java
---
    @@ -31,6 +31,48 @@
     
     public class ${className} {
     
    +/* Dummy function template to allow Optiq to validate this function call.
    + * At DrillOptiq time we rewrite all date_part() functions to extract functions,
    + * since they are essentially the same
    + */
    +@FunctionTemplate(name = "DATE_PART", scope = FunctionTemplate.FunctionScope.SIMPLE,
nulls = FunctionTemplate.NullHandling.NULL_IF_NULL)
    --- End diff --
    
    This is one of the dummy functions we were discussing above. I think this dummy might
look less meaningful if it is checked-in alone.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message