drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request: Drill 4372 for review
Date Fri, 19 Feb 2016 21:46:06 GMT
Github user jinfengni commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java
    @@ -216,6 +217,20 @@ public void eval() {
       @FunctionTemplate(names = {"char_length", "character_length", "length"}, scope = FunctionScope.SIMPLE,
nulls = NullHandling.NULL_IF_NULL)
    +  public static class DummyCharLength implements DrillSimpleFunc {
    --- End diff --
    Why do we add this new "char_length" implementation with empty body? 

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message