drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4387: GroupScan or ScanBatchCreator shou...
Date Thu, 18 Feb 2016 18:41:52 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/379#discussion_r53360482
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/GroupScan.java
---
    @@ -35,6 +35,8 @@
     public interface GroupScan extends Scan, HasAffinity{
     
       public static final List<SchemaPath> ALL_COLUMNS = ImmutableList.of(SchemaPath.getSimplePath("*"));
    +  public static final List<SchemaPath> EMPTY_COLUMNS = ImmutableList.of();
    --- End diff --
    
    Nice catch. It's no longer needed. (Originally, I intended to convert NULL to empty_columns.
But not it's not necessary). I'll remove that. thx. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message