drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adeneche <...@git.apache.org>
Subject [GitHub] drill pull request: Drill 4260: Adding support for "some" custom f...
Date Thu, 18 Feb 2016 17:30:39 GMT
Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/340#discussion_r53349474
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/WindowPOP.java
---
    @@ -33,26 +35,29 @@
       private final NamedExpression[] withins;
       private final NamedExpression[] aggregations;
       private final Order.Ordering[] orderings;
    -  private final long start;
    -  private final long end;
    +  private final boolean rows;
    --- End diff --
    
    the SQL reference refers to this as "window frame units". Renaming to frameUnitsRows


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message