drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4287: During initial DrillTable creation...
Date Wed, 17 Feb 2016 04:34:34 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/376#discussion_r53120105
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java
---
    @@ -47,6 +49,14 @@
       public List<String> files;
       public final String selectionRoot;
     
    +  private enum StatusType {
    +    CHECKED_DIRS,        // whether we have already checked for directories
    +    HAS_DIRS,            // whether directories were found in the selection
    +    EXPANDED_DIRS        // whether this selection has been expanded to files
    +  }
    +
    +  private final BitSet dirStatus;
    --- End diff --
    
    Yeah, there was probably some disconnect since your previous comment  was a little succinct
:).  I was trying to keep track of multiple states, but agree it can be simplified.  I may
not need to use enumerator constructors. I will post an updated patch once I get a clean test
run.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message