drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4275: create TransientStore for short-li...
Date Mon, 15 Feb 2016 23:57:35 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/coord/local/LocalClusterCoordinator.java
    @@ -125,6 +127,11 @@ public DistributedSemaphore getSemaphore(final String name, final
int maximumLea
         return semaphores.get(name);
    +  @Override
    +  public <V> TransientStore<V> getOrCreateTransientStore(final TransientStoreConfig<V>
config) {
    +    return new MapBackedStore<>(config);
    --- End diff --
    Looks like we are creating a new MapBackedStore for every call to this. There is no caching
factory in the call path to this method either.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message