drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4275: create TransientStore for short-li...
Date Mon, 15 Feb 2016 23:48:20 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/374#discussion_r52954392
  
    --- Diff: contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/config/HBasePersistentStoreProvider.java
---
    @@ -41,10 +39,8 @@
     import org.apache.hadoop.hbase.client.HTableInterface;
     import org.apache.hadoop.hbase.util.Bytes;
     
    -import com.google.common.annotations.VisibleForTesting;
    -
    -public class HBasePStoreProvider implements PStoreProvider {
    -  static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(HBasePStoreProvider.class);
    +public class HBasePersistentStoreProvider extends BasePersistentStoreProvider {
    +  static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(HBasePersistentStoreProvider.class);
    --- End diff --
    
    _private_ for all loggers of *Provider and *Store would be nice :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message