drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4275: create TransientStore for short-li...
Date Mon, 15 Feb 2016 02:45:51 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/374#discussion_r52855320
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
    @@ -206,6 +205,16 @@ public DistributedSemaphore getSemaphore(String name, int maximumLeases)
{
         return new ZkDistributedSemaphore(curator, "/semaphore/" + name, maximumLeases);
       }
     
    +  @Override
    +  public <V> TransientStore<V> newTransientStore(final TransientStoreConfig<V>
config) {
    +    final ZkEphemeralStore<V> store = new ZkEphemeralStore<>(config, curator);
    --- End diff --
    
    I think you need to cache these since each one will create a listener. This used to be
done by cachingstoreprovider but I don't think that is in the Transient path anymore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message