drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4275: create TransientStore for short-li...
Date Mon, 15 Feb 2016 02:41:28 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/374#discussion_r52855187
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/serialization/InstanceSerializer.java
---
    @@ -6,20 +6,20 @@
      * to you under the Apache License, Version 2.0 (the
      * "License"); you may not use this file except in compliance
      * with the License.  You may obtain a copy of the License at
    - *
    + * <p/>
      * http://www.apache.org/licenses/LICENSE-2.0
    - *
    + * <p/>
      * Unless required by applicable law or agreed to in writing, software
      * distributed under the License is distributed on an "AS IS" BASIS,
      * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
      * See the License for the specific language governing permissions and
      * limitations under the License.
      */
    -package org.apache.drill.exec.store.sys.serialize;
    +package org.apache.drill.exec.serialization;
     
     import java.io.IOException;
     
    -public interface PClassSerializer<X> {
    -  public byte[] serialize(X val) throws IOException;
    -  public X deserialize(byte[] bytes) throws IOException;
    +public interface InstanceSerializer<T> {
    +  byte[] serialize(T instance) throws IOException;
    --- End diff --
    
    Since you are cleaning this up, I'm thinking that maybe we should consolidate this and
the CustomSerDe interface I added to CustomTunnel and move these some place general (common.serde?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message