drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4275: create TransientStore for short-li...
Date Mon, 15 Feb 2016 02:37:05 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/374#discussion_r52855054
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/coord/ClusterCoordinator.java
---
    @@ -60,16 +62,23 @@
       public abstract DistributedSemaphore getSemaphore(String name, int maximumLeases);
     
       /**
    +   * Returns a new {@link TransientStore store} instance with the given {@link TransientStoreConfig
configuration}.
    +   * @param config  store configuration
    +   * @param <V>  value type for this store
    +   */
    +  public abstract <V> TransientStore<V> newTransientStore(TransientStoreConfig<V>
config);
    +
    +  /**
        * Actions to take when there are a set of new de-active drillbits.
        * @param unregisteredBits
        */
    -  public void drillbitUnregistered(Set<DrillbitEndpoint> unregisteredBits) {
    +  protected void drillbitUnregistered(Set<DrillbitEndpoint> unregisteredBits) {
    --- End diff --
    
    Why the change to protected?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message