drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request: Drill 4260: Adding support for "some" custom f...
Date Thu, 11 Feb 2016 21:44:58 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/340#discussion_r52672160
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/window/TestWindowFrame.java
---
    @@ -106,6 +106,60 @@ public void testMultipleFramers() throws Exception {
         );
       }
     
    +  @Test
    +  public void testUnboundedFollowing() throws Exception {
    +    testBuilder()
    +      .sqlQuery(getFile("window/q3.sql"), TEST_RES_PATH)
    +      .ordered()
    +      .sqlBaselineQuery(getFile("window/q4.sql"), TEST_RES_PATH)
    +      .build()
    +      .run();
    +  }
    +
    +  @Test
    +  public void testAggregateRowsUnboundedAndCurrentRow() throws Exception {
    +    final String table = "dfs_test.`"+TEST_RES_PATH+"/window/b4.p4`";
    +    testBuilder()
    +      .sqlQuery(getFile("window/aggregate_rows_unbounded_current.sql"), table)
    +      .ordered()
    +      .sqlBaselineQuery(getFile("window/aggregate_rows_unbounded_current_baseline.sql"),
table)
    +      .build()
    +      .run();
    +  }
    +
    +  @Test
    +  public void testLastValueRowsUnboundedAndCurrentRow() throws Exception {
    +    final String table = "dfs_test.`"+TEST_RES_PATH+"/window/b4.p4`";
    +    testBuilder()
    +      .sqlQuery(getFile("window/last_value_rows_unbounded_current.sql"), table)
    +      .unOrdered()
    +      .sqlBaselineQuery(getFile("window/last_value_rows_unbounded_current_baseline.sql"),
table)
    +      .build()
    +      .run();
    +  }
    +
    +  @Test
    +  public void testAggregateRangeCurrentAndCurrent() throws Exception {
    --- End diff --
    
    For the RANGE frame specification, are there unit tests that have the same ORDER-BY value
repeating across multiple batches ?  This will form the peer group for the range...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message