drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4363: Row count based pruning for parque...
Date Thu, 11 Feb 2016 05:35:15 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/371#discussion_r52565738
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
    @@ -485,12 +486,14 @@ public void populatePruningVector(ValueVector v, int index, SchemaPath
column, S
         private EndpointByteMap byteMap;
         private int rowGroupIndex;
         private String root;
    +    private long rowCount;
     
         @JsonCreator
         public RowGroupInfo(@JsonProperty("path") String path, @JsonProperty("start") long
start,
    -        @JsonProperty("length") long length, @JsonProperty("rowGroupIndex") int rowGroupIndex)
{
    +        @JsonProperty("length") long length, @JsonProperty("rowGroupIndex") int rowGroupIndex,
long rowCount) {
    --- End diff --
    
    Add the comment.
    
    Pass -1 as rowCount in an unused method TestAffinityCalculator.buildRowGroups(). That
is just to make code compile.   


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message