drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4380: Fix performance regression: in cre...
Date Tue, 09 Feb 2016 21:30:21 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/369#discussion_r52376878
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java
---
    @@ -183,12 +194,16 @@ private static String buildPath(final String[] path, final int folderIndex)
{
       }
     
       public static FileSelection create(final DrillFileSystem fs, final String parent, final
String path) throws IOException {
    +    Stopwatch timer = Stopwatch.createStarted();
         final Path combined = new Path(parent, removeLeadingSlash(path));
         final FileStatus[] statuses = fs.globStatus(combined);
         if (statuses == null) {
           return null;
         }
    -    return create(Lists.newArrayList(statuses), null, combined.toUri().toString());
    +    final FileSelection fileSel = create(Lists.newArrayList(statuses), null, combined.toUri().toString());
    +    logger.info("FileSelection.create() took {} ms ", timer.elapsed(TimeUnit.MILLISECONDS));
    --- End diff --
    
    INFO => DEBUG


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message