drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4380: Fix performance regression: in cre...
Date Tue, 09 Feb 2016 21:27:35 GMT
Github user jacques-n commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java
    @@ -233,7 +233,7 @@ private FileSelection expandSelection(DrillFileSystem fs, FileSelection
             // /a/b/c.parquet and the format of the selection root must match that of the
file names
             // otherwise downstream operations such as partition pruning can break.
             final Path metaRootPath = Path.getPathWithoutSchemeAndAuthority(metaRootDir.getPath());
    -        final FileSelection newSelection = FileSelection.create(null, fileNames, metaRootPath.toString());
    +        final FileSelection newSelection = new FileSelection(selection.getStatuses(fs),
fileNames, metaRootPath.toString());
    --- End diff --
    It seems like we keep having issues with misuse of this interface which causes planning
regressions. Do you think it makes sense to either change the api or add additional comments
to make sure people aren't doing the wrong thing?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message