drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaltekruse <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4327: Fix rawtypes warnings emitted by c...
Date Fri, 05 Feb 2016 17:51:08 GMT
Github user jaltekruse commented on a diff in the pull request:

    https://github.com/apache/drill/pull/347#discussion_r52048800
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/partitionsender/PartitionerDecorator.java
---
    @@ -26,13 +26,13 @@
     import org.apache.drill.exec.ops.FragmentContext;
     import org.apache.drill.exec.ops.OperatorStats;
     import org.apache.drill.exec.record.RecordBatch;
    -
    --- End diff --
    
    don't have a very strong opinion on this, but there seem to be a lot of shifting of imports
without actually changing them, are you standardizing the order? I don't think we have a lot
of outstanding patches that will have merge issues as a result, but we generally try to avoid
cosmetic changes, especially mixed in with other work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message