drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaltekruse <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4314: Unit Test Framework can support sc...
Date Thu, 04 Feb 2016 17:44:29 GMT
Github user jaltekruse commented on a diff in the pull request:

    https://github.com/apache/drill/pull/339#discussion_r51908667
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestBuilder.java ---
    @@ -235,6 +240,20 @@ public CSVTestBuilder csvBaselineFile(String filePath) {
             expectedNumBatches);
       }
     
    +  public SchemaTestBuilder schemaBaseLine(List<Pair<SchemaPath, TypeProtos.MajorType>>
expectedSchema) {
    +    assert expectedSchema != null : "The expected schema can be provided once";
    +    assert baselineColumns == null : "The column information should be captured in expected
schem, not baselineColumns";
    --- End diff --
    
    Could you add a few tests to the TestFrameworkTest that hit these conditions? It would
be good if future changes to the test builder that may cause some currently-valid test configurations
to fail (or currently invalid configurations to be allowed) would be detected by the tests
for the framework itself.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message