drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4287: During initial DrillTable creation...
Date Tue, 02 Feb 2016 03:26:57 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/345#discussion_r51518520
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java
---
    @@ -118,13 +133,34 @@ public boolean apply(@Nullable FileStatus status) {
           }
         }));
     
    -    return create(nonDirectories, null, selectionRoot);
    +    final FileSelection fileSel = create(nonDirectories, null, selectionRoot);
    --- End diff --
    
    Does it make sense to pass in the list of Files in addition to the list of FileStatus?
I thought the implicit assumption for FileSelection is list of files goes first before FileStatus.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message