Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: jacques-n <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-327-drill@git.apache.org>
In-Reply-To: <git-pr-327-drill@git.apache.org>
Subject: [GitHub] drill pull request: DRILL-4131: Move RPC allocators under
 Drill's ...
Content-Type: text/plain
Message-Id: <20160118190121.CAF1BE00DC@git1-us-west.apache.org>
Date: Mon, 18 Jan 2016 19:01:21 +0000 (UTC)

Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/327#discussion_r50033277
  
    --- Diff: exec/memory/base/src/main/java/io/netty/buffer/PooledByteBufAllocatorL.java ---
    @@ -59,7 +59,7 @@ public PooledByteBufAllocatorL(MetricRegistry registry) {
     
       public UnsafeDirectLittleEndian allocate(int size) {
         try {
    -      return allocator.directBuffer(size, size);
    +      return allocator.directBuffer(size, Integer.MAX_VALUE);
    --- End diff --
    
    The RPC uses ensureWritable to expand buffers. Buffers are expandable to maxCapacity. We were coding maxCapacity == capacity which meant that buffers weren't expandable and the RPC layer would error out. This fixes this issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---