drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hnfgns <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4275: Refactor e/pstore interfaces and t...
Date Fri, 15 Jan 2016 23:36:51 GMT
Github user hnfgns commented on the pull request:

    https://github.com/apache/drill/pull/325#issuecomment-172126518
  
    I took the API somewhat Drill internal but you are right about discussing this in the
public list first. This patch -as the numbers above check out- is more of a clean-up than
an extension. My plan was to discuss possible changes to API going forward once this clean-up
patch made its way to master. Here is the rationale: I spent quite a while trying to understand
the current design, event flow in the API in an attempt to find a way for subscribing to store
events. Especially being notified when an ephemeral node dies just like what Zookeeper watches
offer. I got confused multiple times with E/PStore and E/PStoreProvider distinction at interface
level as it seems redundant. That's how the idea of this clean-up patch rolled out. 
    
    As for naming, I am open for non-abbreviated alternates. I would invite developers relying
on this interface to read the documentation first. To this end, I will go ahead and extend
documentation with possible warning areas. 
    
    Please let me know if you want me to address specific issues with this patch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message