drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adeneche <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4270: Create a separate WindowFramer tha...
Date Wed, 13 Jan 2016 23:24:28 GMT
Github user adeneche commented on the pull request:

    https://github.com/apache/drill/pull/322#issuecomment-171470081
  
    The purpose of this PR is to separate the functions that support the FRAME clause in CustomFrameTemplate
from the ones that don't in DefaultFrameTemplate. Work still needs to be done to make the
refactoring complete (like making sure code is not duplicated between the templates), but
I decided to leave it after I make the necessary changes to support the FRAME clause.
    
    @amansinha100 can you please review ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message