Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: jacques-n <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-283-drill@git.apache.org>
In-Reply-To: <git-pr-283-drill@git.apache.org>
Subject: [GitHub] drill pull request: DRILL-4134: Allocator updates
Content-Type: text/plain
Message-Id: <20151214053900.B53A6DFC8E@git1-us-west.apache.org>
Date: Mon, 14 Dec 2015 05:39:00 +0000 (UTC)

Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/283#discussion_r47462883
  
    --- Diff: exec/memory/base/src/main/java/io/netty/buffer/DrillBuf.java ---
    @@ -431,12 +482,18 @@ public boolean equals(Object obj) {
       }
     
       @Override
    -  public synchronized ByteBuf retain(int increment) {
    -    if(rootBuffer){
    -      this.rootRefCnt.addAndGet(increment);
    -    }else{
    -      b.retain(increment);
    +  public ByteBuf retain(int increment) {
    --- End diff --
    
    This is based on the existing DrillBuf. I chose not to deprecate it for now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---