Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: adeneche <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-283-drill@git.apache.org>
In-Reply-To: <git-pr-283-drill@git.apache.org>
Subject: [GitHub] drill pull request: DRILL-4134: Allocator updates
Content-Type: text/plain
Message-Id: <20151201232005.3654EE052E@git1-us-west.apache.org>
Date: Tue,  1 Dec 2015 23:20:05 +0000 (UTC)

Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/283#discussion_r46355284
  
    --- Diff: exec/memory/base/src/main/java/org/apache/drill/exec/memory/RootAllocator.java ---
    @@ -0,0 +1,39 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.exec.memory;
    +
    +import com.google.common.annotations.VisibleForTesting;
    +
    +/**
    + * The root allocator for using direct memory inside a Drillbit. Supports creating a
    + * tree of descendant child allocators.
    + */
    +public class RootAllocator extends BaseAllocator {
    +
    +  public RootAllocator(final long reservation, final long limit) {
    --- End diff --
    
    `Accountant1 makes sure that root allocator doesn't have any reservation. Why not remove `reservation` parameter from this constructor, and just pass 0 to parent ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---