drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hnfgns <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4192: Fix selection root when there is o...
Date Mon, 21 Dec 2015 19:19:43 GMT
Github user hnfgns commented on a diff in the pull request:

    https://github.com/apache/drill/pull/307#discussion_r48179942
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java
---
    @@ -201,7 +202,7 @@ public static FileSelection create(final DrillFileSystem fs, final
String parent
        *
        * @see FileSelection#FileSelection(List, List, String)
        */
    -  public static FileSelection create(final List<FileStatus> statuses, final List<String>
files, final String root) {
    +  public static FileSelection create(final List<FileStatus> statuses, final List<String>
files, String root) {
    --- End diff --
    
    I would recommend avoiding the re-assignment to root.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message